Re: [PATCH 02/10] media: i2c: ov9282: fix line time and exposure time calculation

From: Richard Leitner

Date: Thu Sep 17 2026 - 10:56:07 EST


Hi Bryan,

thanks for your feedback!

On Thu, Sep 17, 2026 at 11:51:46AM +0100, Bryan O'Donoghue wrote:
> On 14/09/2026 20:20, Richard Leitner wrote:
> > The right
> > clock is PLL2's system clock. With the PLL2 dividers left at their reset
> > values the chain
>
> I think this statement could use some more justification for the commit log.

Which part do you mean? That "PLL2's system clock" is the right clock?
Or the "dividers left at their reset values"?
Or both? :-)

>
> PLL2 is stated in the data-sheet ?

Yes, PLL2 and its clock dividers are described in the datasheet (similar
to the formular shown in the commit message).

The fact that "PLL2's system clock" is the right for this, i.e. proof that
OV9282_REG_TIMING_HTS is counted in increments of it is according to my
research not available in the datasheet.

>
> Either way
>
> Fixes:
> Cc: stable@xxxxxxxxxxxxxxx

As this whole series basically fixes things, would it be acceptable to add
the Cc for all patches?

>
> ---
> bod

regards;rl