Re: [PATCH net-next 05/10] netlink: specs: devlink: fix resource-scope type

[Moshe Shemesh]

On 9/12/2026 12:41 AM, Asbjørn Sloth Tønnesen wrote:
> The correct type for resource-scope is flags, not enum:
>
> - DEVLINK_RESOURCE_SCOPE_DEV is _BITUL(0) aka. 1, not 0.
> - DEVLINK_RESOURCE_SCOPE_PORT is _BITUL(1) aka. 2, not 1.

Note that once the resource-scope is defined as flags, the 
"enum-as-flags: true" on resource-scope-mask is redundant - please drop it.

With that:
Reviewed-by: Moshe Shemesh <moshe@xxxxxxxxxx>

> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> CC: Cosmin Ratiu <cratiu@xxxxxxxxxx>
> CC: Jiri Pirko <jiri@xxxxxxxxxxx>
> CC: Moshe Shemesh <moshe@xxxxxxxxxx>
> CC: Or Har-Toov <ohartoov@xxxxxxxxxx>
> CC: Tariq Toukan <tariqt@xxxxxxxxxx>
> ---
>   Documentation/netlink/specs/devlink.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
> index 38b1190f3d26..0b3160e201da 100644
> --- a/Documentation/netlink/specs/devlink.yaml
> +++ b/Documentation/netlink/specs/devlink.yaml
> @@ -158,7 +158,7 @@ definitions:
>         -
>           name: entry
>     -
> -    type: enum
> +    type: flags
>       name: resource-scope
>       entries:
>         -
> --
> 2.55.0