Re: [PATCH v4 07/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller

From: Krzysztof Kozlowski

Date: Fri Sep 18 2026 - 05:54:42 EST


On 17/09/2026 11:15, Larisa Grigore wrote:
> +
> +properties:
> + compatible:
> + items:
> + - const: nxp,s32n79-ufshc
> + - const: jedec,ufs-2.0

Continuing discussion from v1, why replacing one fallback with another?
So previously it was compatible with 3.0, but now it is not and it
became compatible with 2.0?

I cannot find any software user of any of these fallbacks, thus IMO it
should be dropped, unless UFS folks have some arguments for keeping it?

> +
> + reg:
> + items:
> + - description: UFS Host Controller registers
> + - description: System Control Module registers
> +
> + reg-names:
> + items:
> + - const: ufshc
> + - const: scm
> +
> + clocks:
> + maxItems: 1
> + description: UFS core clock

Drop description, redundant.

> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> +
Best regards,
Krzysztof