Re: [PATCH v2 2/3] dt-bindings: usb: Introduce samsung,snps-dwc3

[Krzysztof Kozlowski]

On Wed, Sep 16, 2026 at 05:52:28PM +0530, Selvarasu Ganesan wrote:
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> +  - Selvarasu Ganesan <selvarasu.g@xxxxxxxxxxx>
> +
> +description:
> +  Describes the DWC3 USB controller block implemented on Samsung Exynos SoCs.
> +
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: samsung,snps-dwc3
> +  required:
> +    - compatible

This select is not needed.

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - samsung,exynos8855-dwc3
> +      - const: samsung,snps-dwc3

And this fallback is not really accurate. Samsung does not have snps
device, because snps is a vendor. Anyway, generic fallbacks should go
away, drop, so you are left with samsung,exynos8855-dwc3 only.

Filename should be then samsung,exynos8855-dwc3.yaml.

> +
> +  reg:
> +    maxItems: 1
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    description: |
> +      Several clocks are used, depending on the variant. Typical ones are:
> +       - ref: Reference clock for SOF/ITP generation.
> +       - bus: Bus (APB) clock for register access.

You have only one variant, no? Or you mean one SoC has different
variants?

> +    minItems: 1
> +    maxItems: 4

Nope, you to list items.

> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 4
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +
> +allOf:
> +  - $ref: snps,dwc3-common.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,exynos8855-dwc3
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2

How can it be two if you have ONLY one device in the binding and that
device has between 1 and 4?

This entire if is redundant, no? How many clocks do you actually have
there?

> +        clock-names:
> +          items:
> +            - const: ref
> +            - const: bus
> +
> +unevaluatedProperties: false

Best regards,
Krzysztof