Re: [PATCH v2 2/4] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Bhargav Joshi]

On Fri, Sep 18, 2026 at 6:12 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
>
> On Wed, 16 Sep 2026 02:29:39 +0530
> Bhargav Joshi <j.bhargav.u@xxxxxxxxx> wrote:
>
> > The omap-sham, omap4-des and omap2-aes crypto drivers do not use
> > "clocks" and "clock-names" properties. Clock management is handled by
> > the ti-sysc interconnect parent wrapper. The dt-bindings for
> > ti,omap-sham and ti,omap-aes don't define these clock properties. Having
> > them in the child nodes causes dtbs_check warnings.
> >
> > Remove the "clocks" and "clock-names" properties from the sham, des and
> > aes nodes.
> >
> > Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>
>
> I was a bit too fast here, clocks here are different from what is
> used in the ti-sysc block. So some more thought and argumenting is needed.
Clocking is handled by ti-sysc parent block, furthermore other dtsi
such as omap5,
omap4, am4372 which uses the same hardware doesn't define any clock in
the child node.
parent block defines a clock with clock-name: fck
clocks = <&l4sec_clkctrl DRA7_L4SEC_AES2_CLKCTRL 0>;
clock-names = "fck";
and child main part as
clocks = <&l3_iclk_div>;
clock-names = "fck";
If child node needs this separate clock  in child node then binding
for aes and sham needs
to be updated to allow clocks and clock-names leaving des binding as it is.

Best Regards,
Bhargav
>
> Regards,
> Andreas
>
> > ---
> >  arch/arm/boot/dts/ti/omap/dra7-l4.dtsi | 2 --
> >  arch/arm/boot/dts/ti/omap/dra7.dtsi    | 8 --------
> >  2 files changed, 10 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> > index a595745afe59..bca035fd7e62 100644
> > --- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> > +++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> > @@ -2086,8 +2086,6 @@ des: des@0 {
> >                               interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
> >                               dmas = <&sdma_xbar 117>, <&sdma_xbar 116>;
> >                               dma-names = "tx", "rx";
> > -                             clocks = <&l3_iclk_div>;
> > -                             clock-names = "fck";
> >                       };
> >               };
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> > index 711ce4c31bb1..0784c6d9cbe4 100644
> > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
> > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> > @@ -1012,8 +1012,6 @@ aes1: aes@0 {
> >                               interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> >                               dmas = <&edma_xbar 111 0>, <&edma_xbar 110 0>;
> >                               dma-names = "tx", "rx";
> > -                             clocks = <&l3_iclk_div>;
> > -                             clock-names = "fck";
> >                       };
> >               };
> >
> > @@ -1043,8 +1041,6 @@ aes2: aes@0 {
> >                               interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> >                               dmas = <&edma_xbar 114 0>, <&edma_xbar 113 0>;
> >                               dma-names = "tx", "rx";
> > -                             clocks = <&l3_iclk_div>;
> > -                             clock-names = "fck";
> >                       };
> >               };
> >
> > @@ -1073,8 +1069,6 @@ sham1: sham@0 {
> >                               interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
> >                               dmas = <&edma_xbar 119 0>;
> >                               dma-names = "rx";
> > -                             clocks = <&l3_iclk_div>;
> > -                             clock-names = "fck";
> >                       };
> >               };
> >
> > @@ -1103,8 +1097,6 @@ sham2: sham@0 {
> >                               interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> >                               dmas = <&edma_xbar 165 0>;
> >                               dma-names = "rx";
> > -                             clocks = <&l3_iclk_div>;
> > -                             clock-names = "fck";
> >                       };
> >               };
> >
> >
>