Re: [PATCH v2 2/4] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Andreas Kemnade]

On Wed, 16 Sep 2026 02:29:39 +0530
Bhargav Joshi <j.bhargav.u@xxxxxxxxx> wrote:

> The omap-sham, omap4-des and omap2-aes crypto drivers do not use
> "clocks" and "clock-names" properties. Clock management is handled by
> the ti-sysc interconnect parent wrapper. The dt-bindings for
> ti,omap-sham and ti,omap-aes don't define these clock properties. Having
> them in the child nodes causes dtbs_check warnings.
> 
> Remove the "clocks" and "clock-names" properties from the sham, des and
> aes nodes.
> 
> Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>

I was a bit too fast here, clocks here are different from what is
used in the ti-sysc block. So some more thought and argumenting is needed.

Regards,
Andreas

> ---
>  arch/arm/boot/dts/ti/omap/dra7-l4.dtsi | 2 --
>  arch/arm/boot/dts/ti/omap/dra7.dtsi    | 8 --------
>  2 files changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> index a595745afe59..bca035fd7e62 100644
> --- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> @@ -2086,8 +2086,6 @@ des: des@0 {
>  				interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&sdma_xbar 117>, <&sdma_xbar 116>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> index 711ce4c31bb1..0784c6d9cbe4 100644
> --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> @@ -1012,8 +1012,6 @@ aes1: aes@0 {
>  				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 111 0>, <&edma_xbar 110 0>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1043,8 +1041,6 @@ aes2: aes@0 {
>  				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 114 0>, <&edma_xbar 113 0>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1073,8 +1069,6 @@ sham1: sham@0 {
>  				interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 119 0>;
>  				dma-names = "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1103,8 +1097,6 @@ sham2: sham@0 {
>  				interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 165 0>;
>  				dma-names = "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
>