Re: [PATCH] staging: media: atomisp: remove ia_css_circbuf_t typedef

[Andy Shevchenko]

On Fri, Sep 18, 2026 at 09:41:32PM +0000, Rareș-Mihai Vladu wrote:
> Remove typedef ia_css_circbuf_t and use struct ia_css_circbuf_s
> directly, as per kernel coding style (chapter 5).

...

>  void ia_css_circbuf_create(
> -    ia_css_circbuf_t *cb,
> +	struct ia_css_circbuf_s *cb,
>      ia_css_circbuf_elem_t *elems,
>      ia_css_circbuf_desc_t *desc);

So, this is half baked patch. But even if it was the full one, the problem with
it that it does nothing useful. The useful change here is to refactor this to
use either circbuf or kfifo Linux kernel APIs.

...

TL;DR: Try more useful task first, please.

-- 
With Best Regards,
Andy Shevchenko