Re: [PATCH v4 2/2] iio: light: add AS7343 multi-spectral sensor driver

[Andy Shevchenko]

On Fri, Sep 18, 2026 at 08:46:18PM -0700, Chang Yu wrote:
> On Mon, Sep 14, 2026 at 11:00:18AM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 11, 2026 at 06:39:12PM -0700, Chang Yu wrote:

...

> > > +/* AS7343 FIFO buffer data registers */
> > > +#define AS7343_FIFO_LVL		0xfd
> > > +#define AS7343_FDATA_L		0xfe
> > > +#define AS7343_FDATA_H		0xff
> > 
> > Please, keep indentation for the registers the same. Also would be nice to have
> > them sorted by offset.
> > 
> Due to the register layout sometimes registers with similar
> functions/purposes are scattered across the address space. As a
> compromise I'll group registers by purposes and sort by offset within
> the same group.

I understand your motivation, but it makes list of the definitions harder to
follow. Are they also grouped like this in the official datasheet? If so,
no problems then, otherwise consider following the suggestion.

-- 
With Best Regards,
Andy Shevchenko