Re: [PATCH v4 2/2] iio: light: add AS7343 multi-spectral sensor driver

[Chang Yu]

On Mon, Sep 14, 2026 at 11:00:18AM +0300, Andy Shevchenko wrote:
> On Fri, Sep 11, 2026 at 06:39:12PM -0700, Chang Yu wrote:
> > +#define AS7343_ID				0x5a
> 
> > +/* AS7343 config registers */
> > +#define AS7343_ENABLE				0x80
> 
> > +#define AS7343_ATIME				0x81
> 
> > +#define AS7343_ASTEP				0xd4
> 
> 
> > +#define AS7343_CFG0				0xbf
> > +
> > +#define AS7343_CFG1				0xc6
> 
> > +#define AS7343_CFG20				0xd6
> 
> > +#define AS7343_CONTROL				0xfa
> > +
> > +/* AS7343 status registers */
> > +#define AS7343_STATUS2				0x90
> > +#define AS7343_STATUS3				0x91
> > +#define AS7343_STATUS				0x93
> > +#define AS7343_ASTATUS				0x94
> > +#define AS7343_STATUS5				0xbb
> > +#define AS7343_STATUS4				0xbc
> > +#define AS7343_FD_STATUS			0xe3
> > +
> > +/* AS7343 spectral data registers */
> > +#define AS7343_DATA_FZ		0x95
> > +#define AS7343_DATA_FY		0x97
> > +#define AS7343_DATA_FXL		0x99
> > +#define AS7343_DATA_NIR		0x9b
> > +#define AS7343_DATA_F2		0xa1
> > +#define AS7343_DATA_F3		0xa3
> > +#define AS7343_DATA_F4		0xa5
> > +#define AS7343_DATA_F6		0xa7
> > +#define AS7343_DATA_F1		0xad
> > +#define AS7343_DATA_F7		0xaf
> > +#define AS7343_DATA_F8		0xb1
> > +#define AS7343_DATA_F5		0xb3
> > +#define AS7343_DATA_FD_L	0xb7
> > +#define AS7343_DATA_FD_H	0xb8
> 
> > +/* AS7343 FIFO buffer data registers */
> > +#define AS7343_FIFO_LVL		0xfd
> > +#define AS7343_FDATA_L		0xfe
> > +#define AS7343_FDATA_H		0xff
> 
> Please, keep indentation for the registers the same. Also would be nice to have
> them sorted by offset.
> 
Due to the register layout sometimes registers with similar
functions/purposes are scattered across the address space. As a
compromise I'll group registers by purposes and sort by offset within
the same group.