Re: [PATCH v4 07/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller
From: Larisa Ileana Grigore
Date: Mon Sep 21 2026 - 04:22:44 EST
On 9/18/2026 12:49 PM, Krzysztof Kozlowski wrote:
On 17/09/2026 11:15, Larisa Grigore wrote:Thank you! I will drop the JEDEC fallback compatible. Looking at the existing UFS bindings, not all controllers provide such a fallback (for example, Renesas UFS controllers), and I could not identify any software user for it either.
+
+properties:
+ compatible:
+ items:
+ - const: nxp,s32n79-ufshc
+ - const: jedec,ufs-2.0
Continuing discussion from v1, why replacing one fallback with another?
So previously it was compatible with 3.0, but now it is not and it
became compatible with 2.0?
I cannot find any software user of any of these fallbacks, thus IMO it
should be dropped, unless UFS folks have some arguments for keeping it?
I will drop it.+
+ reg:
+ items:
+ - description: UFS Host Controller registers
+ - description: System Control Module registers
+
+ reg-names:
+ items:
+ - const: ufshc
+ - const: scm
+
+ clocks:
+ maxItems: 1
+ description: UFS core clock
Drop description, redundant.
+Best regards,
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+
Krzysztof
Regards,
Larisa