Re: [EXTERNAL] Re: [PATCH v5] ASoC: tas2783-sdw: add firmware download status check

[Mark Brown]

On Mon, Sep 21, 2026 at 09:22:23AM +0000, Xu, Baojun wrote:

> > > +     /* Check if the AMP is in reset status. */
> > > +     if (val == 0x20) {
> > > +             tas_dev->fw_dl_success = false;

> > I'm still not seeing where fw_dl_success gets set to true if the
> > download was skipped.

> If download was skipped, it should be true.

As I said on the previous version can you guarantee that the driver is
being probed with the device having been reset?  What happens if
something earlier in the boot process left it running, or the driver was
removed and reprobed?  The logic only works currently if the driver did
the download that it's skipping.

Attachment: signature.asc
Description: PGP signature