Re: [EXTERNAL] Re: [PATCH v5] ASoC: tas2783-sdw: add firmware download status check

[Xu, Baojun]

> 
> ________________________________________
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: 21 September 2026 17:27
> To: Xu, Baojun
> Cc: tiwai@xxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; Ding, Shenghao; linux-sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Yi, Ken; Lo, Henry; Chen, Robin; Holalu Yogendra, Niranjan; pin-hao.huang@xxxxxx; Syed.SabaKareem@xxxxxxx
> Subject: Re: [EXTERNAL] Re: [PATCH v5] ASoC: tas2783-sdw: add firmware download status check
> 
> On Mon, Sep 21, 2026 at 09:22:23AM +0000, Xu, Baojun wrote:
> 
> > > > +     /* Check if the AMP is in reset status. */
> > > > +     if (val == 0x20) {
> > > > +             tas_dev->fw_dl_success = false;
> 
> > > I'm still not seeing where fw_dl_success gets set to true if the
> > > download was skipped.
> 
> > If download was skipped, it should be true.
> 
> As I said on the previous version can you guarantee that the driver is
> being probed with the device having been reset?  What happens if
> something earlier in the boot process left it running, or the driver was
> removed and reprobed?  The logic only works currently if the driver did
> the download that it's skipping.
> 
Previously, a local variable tracked the AMP reset state to determine if a
firmware download was required. However, we observed that the AMP resets
during SoundWire bus stop/start sequences, causing the variable to become
stale. To improve stability, the driver now directly reads the register
value instead of relying on the cached variable.
This version has been verified to work correctly on the current platform.
Given the customer's urgent need, could you please help apply this patch?
This will allow the customer to proceed with further testing immediately.
Version 6 will be released shortly.

Best Regards
Jim