Re: [PATCH] scsi: efct: clear MWI on remove

From: Daniel Wagner

Date: Mon Sep 21 2026 - 08:36:57 EST


On Sat, Sep 19, 2026 at 02:13:26AM +0800, Guangshuo Li wrote:
> efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
> The probe failure path clears this state with pci_clear_mwi(), but the
> normal remove path does not perform the corresponding cleanup.
>
> pci_disable_device() only disables PCI bus mastering and does not clear
> the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
> remain enabled after the driver is removed.
>
> Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
> path.
>
> This issue was found by manual code inspection.
>
> Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>

Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>