Re: [PATCH] scsi: efct: clear MWI on remove

[krzk]

On Sat, 19 Sep 2026 02:13:26 +0800, Guangshuo Li wrote:
> efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
> The probe failure path clears this state with pci_clear_mwi(), but the
> normal remove path does not perform the corresponding cleanup.
> 
> pci_disable_device() only disables PCI bus mastering and does not clear
> the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
> remain enabled after the driver is removed.
> 
> Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
> path.
> 
> This issue was found by manual code inspection.
> 
> Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> ---
>  drivers/scsi/elx/efct/efct_driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 


You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem, how to document usage of LLM and how what you should not
do if this was posted in a good faith.

Best regards,
Krzysztof