Re: [PATCH 3/3] iomap: don't lose a failed direct I/O bio's error when zeroing the tail

[Christoph Hellwig]

On Mon, Sep 21, 2026 at 03:34:32PM -0700, Darrick J. Wong wrote:
> > -		if (pad)
> > -			ret = iomap_dio_zero(iter, dio, pos,
> > -					     fs_block_size - pad);
> > +		if (pad) {
> > +			ssize_t zerror;
> 
> Why ssize_t?  iomap_dio_zero returns int, right?  I may have missed
> something in my absence, but AFAICT it should be:

More importantly iomap_dio_zero can only return an error for a
logic bomb assert using WARN_ON.  I'd suggest to simply return without
an error there and remove the handling of the iomap_dio_zero return
value entirely, as it clearly casues more harm than it helps.