Re: [PATCH 3/3] iomap: don't lose a failed direct I/O bio's error when zeroing the tail
From: Andrea Parri
Date: Tue Sep 22 2026 - 05:12:34 EST
> > Why ssize_t? iomap_dio_zero returns int, right?
>
> More importantly iomap_dio_zero can only return an error for a
> logic bomb assert using WARN_ON. I'd suggest to simply return without
> an error there and remove the handling of the iomap_dio_zero return
> value entirely, as it clearly casues more harm than it helps.
Agreed, that's cleaner than retyping the local. I'll drop the
zerror/ret handling entirely for v2 and just call iomap_dio_zero()
without capturing its return.
Darrick, that also answers your question, the type mismatch goes
away since there's no local variable left.
Thanks!
Andrea