Re: [PATCH v3 33/33] gpu: nova-core: gsp: match a GMC response by flag, id and sequence

[Alexandre Courbot]

On Fri Sep 18, 2026 at 10:07 AM JST, John Hubbard wrote:
<...>
>  // SAFETY: All fields are integer types with no uninitialized padding bytes.
> @@ -801,7 +817,7 @@ pub(crate) struct GspGmcMsgElement {
>  
>  impl GspGmcMsgElement {
>      /// Creates the queue element header and the GMC API header of a request that carries
> -    /// `payload_size` bytes of payload.
> +    /// `payload_size` bytes of payload under the RPC sequence number `sequence`.
>      ///
>      /// `max_response_size` is the largest response that the sender accepts, and zero for a request
>      /// that GSP-RM does not answer.
> @@ -811,7 +827,7 @@ impl GspGmcMsgElement {
>      /// - `EOVERFLOW` if a length does not fit its 32-bit field.
>      pub(crate) fn init(
>          command_id: u32,
> -        sequence: u64,
> +        sequence: u32,

Why are we changing the type of sequence here? `u64` is the correct type
as it's the one that is stored in the GMC header eventually.

This patch (and the previous one IIUC) repair defects introduced earlier
in the very same series. Let's please settle on the right shape from the
get-go.