[PATCH] staging: rtl8723bs: refactor xmit_xmitframe

From: Eric LI (Honggang)

Date: Thu Sep 24 2026 - 11:23:31 EST


Refactor the function xmit_xmitframe in rtl8723bs_xmit.c to
reduce the leading tabs

Signed-off-by: Eric LI (Honggang) <eric.lee0305@xxxxxxxxx>
---
.../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 43 ++++++++++---------
1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 7f55448d544e..46895b05538d 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -231,29 +231,30 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv

/* check xmit_buf size enough or not */
txlen = txdesc_size + rtw_wlan_pkt_size(pxmitframe);
- if (!pxmitbuf ||
- ((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) ||
- (k >= (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1))
+ if (pxmitbuf &&
+ (((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) ||
+ (k >= (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1)))
) {
- if (pxmitbuf) {
- /* pxmitbuf->priv_data will be NULL, and will crash here */
- if (pxmitbuf->len > 0 &&
- pxmitbuf->priv_data) {
- struct xmit_frame *pframe;
-
- pframe = (struct xmit_frame *)pxmitbuf->priv_data;
- pframe->agg_num = k;
- pxmitbuf->agg_num = k;
- rtl8723b_update_txdesc(pframe, pframe->buf_addr);
- rtw_free_xmitframe(pxmitpriv, pframe);
- pxmitbuf->priv_data = NULL;
- enqueue_pending_xmitbuf(pxmitpriv, pxmitbuf);
- /* can not yield under lock */
- /* yield(); */
- } else
- rtw_free_xmitbuf(pxmitpriv, pxmitbuf);
- }
+ if (pxmitbuf->len > 0 &&
+ pxmitbuf->priv_data) {
+ struct xmit_frame *pframe;
+
+ pframe = (struct xmit_frame *)pxmitbuf->priv_data;
+ pframe->agg_num = k;
+ pxmitbuf->agg_num = k;
+ rtl8723b_update_txdesc(pframe, pframe->buf_addr);
+ rtw_free_xmitframe(pxmitpriv, pframe);
+ pxmitbuf->priv_data = NULL;
+ enqueue_pending_xmitbuf(pxmitpriv, pxmitbuf);
+ /* can not yield under lock */
+ /* yield(); */
+ } else
+ rtw_free_xmitbuf(pxmitpriv, pxmitbuf);
+
+ pxmitbuf = NULL;
+ }

+ if (!pxmitbuf) {
pxmitbuf = rtw_alloc_xmitbuf(pxmitpriv);
if (!pxmitbuf) {
err = -2;
--
2.34.1