Re: [PATCH v2 1/3] dt-bindings: regulator: Add RPMI voltage service bindings

[Mark Brown]

On Wed, Sep 23, 2026 at 10:35:08PM +0200, Krzysztof Kozlowski wrote:
> On 23/09/2026 09:00, Joshua Yeong wrote:

> > +    voltage-service {

> There is no such service. Don't invent names. See DT spec.

Looks like it comes from the RPMI spec:

   https://github.com/riscv-non-isa/riscv-rpmi/blob/main/src/srvgrp-voltage.adoc

> > +  "#voltage-domain-cells" on the provider, a consumer lists
> > +  "voltage-domains = <&provider DOMAIN_ID>" and names each entry in
> > +  "voltage-domain-names", the way it names a voltage power domain. Both
> > +  properties belong to the consumer, so a consumer binding describes them
> > +  itself:

> And where do you explain what is that "voltage domain" and why it is
> completely different than everything else we have?

> No, don't come up with your own naming for standard things.

That also looks like what the spec says (some of the description is
copied pretty closely from the spec).

Attachment: signature.asc
Description: PGP signature