Re: [PATCH v3] drivers/hv: remove deposited pages from direct map

[Mukesh R]

On 9/18/26 03:48, Magnus Kulke wrote:
> On Thu, Sep 17, 2026 at 05:23:15PM -0700, Mukesh R wrote:
> > On 9/17/26 13:10, Magnus Kulke wrote:
> >
> > FYI:
> >
> > https://lore.kernel.org/linux-hyperv/20260912000318.2959621-1-mrathor@xxxxxxxxxxxxxxxxxxx/
> >
> > Thanks,
> > -Mukesh
>
> Thanks, the change to a larger single page makes sense. I assume we
> would still be susceptible to a #GP once the kernel steps into it?
>
> Since this is addressing acute crashes on L1VH, it would be good to
> merge a fix first IMO. it can then be easily cherrypicked into
> backports or distro-kernels.
>
> Or would you rather see the problem addressed as part of in your
> deposit-pages refactoring?

no, we need to backport deposit-pages also (it is already in the
internal 6.18) as not only it enhances the deposit, but also fixes
couple bugs, so best to keep this separate. the deposit patch does
address your comment:

 +     HV_DEPOSIT_MAX is capped at 511, so a deposit range cannot cover
 +    * a 2MiB page, so deposited pages are of 4k granularity and cannot
 +    * be collapses into a 2MiB page, which would require an allocation
 +    * and can potentially fail.

IOW, as soon as it's merged, above will not be true always.

Thanks,
-Mukesh

> best,
>
> magnus