Re: [PATCH 4/6] ASoC: codecs: aw88166: remove fade in/out on start/stop

[Aaron Kling]

On Fri, Sep 25, 2026 at 9:11 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Sep 25, 2026 at 02:47:32AM -0500, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@xxxxxxxxx>
> >
> > This "feature" was copied from downstream, but it does not belong in
> > the kernel at all. Remove it to simplify the driver.
>
> Are you sure?  Some devices have really bad pop/click performance and
> need ramps to mask the effects, we've got other drivers with soft ramps
> in them.

Ditto replies on the other changes. This was accepted for aw88261, is
there anything specific to this driver that doesn't apply there? I
have not experienced any such noise on the AYN and Retroid Pocket
devices that use this amp since making these changes.

Aaron