Re: [PATCH 4/6] ASoC: codecs: aw88166: remove fade in/out on start/stop
From: Mark Brown
Date: Fri Sep 25 2026 - 12:28:36 EST
On Fri, Sep 25, 2026 at 10:59:24AM -0500, Aaron Kling wrote:
> On Fri, Sep 25, 2026 at 9:11 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > Are you sure? Some devices have really bad pop/click performance and
> > need ramps to mask the effects, we've got other drivers with soft ramps
> > in them.
> Ditto replies on the other changes. This was accepted for aw88261, is
> there anything specific to this driver that doesn't apply there? I
> have not experienced any such noise on the AYN and Retroid Pocket
> devices that use this amp since making these changes.
Perhaps as Cezary sugested the changelogs on the aw88261 were better and
didn't set off alarm bells in the same way. I don't know anything in
particular about either of these devices, the drivers aren't the best
but sometimes hardware is also bad.
Attachment:
signature.asc
Description: PGP signature