Re: [PATCH net-next v2 5/9] netlink: specs: ethtool: re-align c33-pse-ext-state

[Hangbin Liu]

On Fri, Sep 25, 2026 at 09:39:08PM +0000, Asbjørn Sloth Tønnesen wrote:
> enum ethtool_c33_pse_ext_state is misaligned with YNL:
> 
> - ETHTOOL_C33_PSE_EXT_STATE_OVLD_DETECTED is 6.
> - ETHTOOL_C33_PSE_EXT_STATE_PD_DLL_POWER_TYPE is 7 (not in YNL).
> - ETHTOOL_C33_PSE_EXT_STATE_POWER_NOT_AVAILABLE is 8, not 7.
> - ETHTOOL_C33_PSE_EXT_STATE_SHORT_DETECTED is 9, not 8.
> 
> In commit c8149739af86 ("netlink: specs: Expand the PSE netlink command
> with C33 new features") the PD_DLL_POWER_TYPE enum member was skipped,
> leading incorrect values for power-not-available and short-detected.
> 
> As PD_DLL_POWER_TYPE is not used, then skip it, but set the value for
> power-not-available to 8.
> 
> CC: Andrew Lunn <andrew@xxxxxxx>
> CC: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> ---
> Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.
> 
>  Documentation/netlink/specs/ethtool.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 5dd4d1b5d94b..439bf24e7c33 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -89,6 +89,7 @@ definitions:
>        -
>          name: power-not-available
>          doc: Group of power_not_available states
> +        value: 8
>        -
>          name: short-detected
>          doc: Group of short_detected states
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>