Re: [PATCH net-next v2 6/9] netlink: specs: ethtool: re-align module-fw-flash-status

[Hangbin Liu]

On Fri, Sep 25, 2026 at 09:39:09PM +0000, Asbjørn Sloth Tønnesen wrote:
> Correct the values for enum ethtool_module_fw_flash_status:
> 
> - ETHTOOL_MODULE_FW_FLASH_STATUS_STARTED is 1, not 0.
> - ETHTOOL_MODULE_FW_FLASH_STATUS_IN_PROGRESS is 2, not 1.
> - ETHTOOL_MODULE_FW_FLASH_STATUS_COMPLETED is 3, not 2.
> - ETHTOOL_MODULE_FW_FLASH_STATUS_ERROR is 4, not 3.
> 
> Re-align the YNL spec by explicitly setting the first value to 1.
> 
> CC: Andrew Lunn <andrew@xxxxxxx>
> CC: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> ---
> Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.
> 
>  Documentation/netlink/specs/ethtool.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 439bf24e7c33..6868eb473478 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -47,6 +47,7 @@ definitions:
>        -
>          name: started
>          doc: The firmware flashing process has started.
> +        value: 1
>        -
>          name: in-progress
>          doc: The firmware flashing process is in progress.
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>