Re: [PATCH v7 3/3] arm64: dts: qcom: Add hamoa Samsung Galaxy Book4 Edge devicetrees

[Maxim Storetvedt]

On 9/28/26 18:44, Antheas Kapenekakis wrote:
> On Sun, 20 Sept 2026 at 20:41, Maxim Storetvedt <mstoretv@xxxxxxx> wrote:
>>
>> Adds devicetrees for the 14-inch and 16-inch hamoa SKUs of the Samsung Galaxy Book4 Edge.
>>
>> These use a common dtsi derived from nodes that were able to work on Linux
>> from the initial Galaxy Book4 Edge DTS by Marcus:
>>
>> Link: https://lore.kernel.org/all/p3mhtj2rp6y2ezuwpd2gu7dwx5cbckfu4s4pazcudi4j2wogtr@4yecb2bkeyms/
>>
>> combined with the patch series the Honor Magicbook Art 14, which shares device similarities:
>>
>> Link: https://lore.kernel.org/all/20260629154812.9066-1-mail@xxxxxxxxxxx/
> 
> Links go in the bottom, Based-on-a-patch is not a thing, you may add a
> Coby as noted in a parallel thread.
> 
>> as well as a few more adjustments on top of that again to get additional features working.
>> Special thanks to Jesse Ahn for helping expand on what would eventually become this dtsi.
> 
> Hi Maxim,
> I tested this series on a kernel with various other backports on two
> european (norwegian market) galaxy book4 edges.
> 
> Specifically, the 14in NP940XMA and the 15.6in (not 16) NP750XQB.
> Specifically, the later is an X1Plus variant that came out a year
> later with cheaper components. It does not work properly on either on
> them. I was hoping that at least the 14in model would work as is but
> no.
> 
> My test devices have proprietary Samsung battery controllers
> (ENE-KB9058) and type C controllers (Samsung EmuEC). Also the speaker
> amplifiers are different. So the battery reporting, audio, and USB C
> ports do not work at all using your DTs. The TPM does not bind either
> but you do not claim that it does. At least they got me to boot and
> for that I am grateful.
> 
> Other stuff also does not work, but I am just listing the main ones.
> 
> I suggest you change the -14/-16 suffixes on both models with
> something more specific.
> 
> The prior patches in the series look fine to my eyes. I did not A/B
> test them, just pulled them in.
> 
> Best,
> Antheas
> 

Hi Antheas,

Thanks for giving it a test! I think we both have the (almost) same
device, and your experience on the 14" NP940XMA (NO) probably mirrors
that of my NP940XMA (IT).

USB-C should already work for this SKU with the patch DT, but not USB-C
hotplug (yet). For now, everything is just left as already set up by the
firmware, so peripherals plugged in after boot will not be detected.
Everything inserted before boot, and hotplug on USB hubs, should still
be fine. Could you give it a try on your device?

Battery state monitoring should also be with the same caveats on both
these devices, going via a separate protocol over I2C instead of
following the other X1Es. There is a separate battery driver for this,
and also other useful patches (like the webcam and kb backlight)
downstream. For now at least, only the features listed in the cover are
included here, but our repo linked there has pointers to the other
relevant patches needed for now.

On that topic, you will also find links to devicetrees for the X1P42100
Book4 Edge there (via Ciscobugger). This might not be the same X1P SKU,
but could also be worth a try.

Cheers,
-Max