Re: [PATCH v13 05/15] cxl: Introduce reusable HDM decoder settings

[Srirangan Madhavan]

On 9/23/26 7:45 PM, Jonathan Cameron wrote:
> Whilst strictly speaking correct, to me struct_group_tagged()
> should only really be used when there is only one place that
> the structure appears.  Otherwise it is just a bit obscure
> to read.  It does give us the option of accessing the elements
> in here without the extra jump, but I'm not sure that is
> a good idea in this case.  So I'd just make this a normal
> structure.  After all what is special about it being
> defined here that isn't equally true of the cxl_decoder_settings
> structure below?

Ack. Now V14 defines struct cxl_decoder_config independently and embeds 
it as a normal member in both cxl_decoder and cxl_decoder_settings. I've 
moved the access changes into a separate mechanical patch, 4/16.

--
Regards,
Srirangan