Re: [PATCH v13 03/15] cxl: Move HDM decoder programming helpers

From: Srirangan Madhavan

Date: Thu Oct 01 2026 - 19:43:16 EST


On 9/23/26 6:29 PM, Jonathan Cameron wrote:
External email: Use caution opening links or attachments


On Tue, 22 Sep 2026 08:39:12 +0000
Srirangan Madhavan <smadhavan@xxxxxxxxxx> wrote:

Move the HDM decoder programming helpers and cxl_rwsem from hdm.c to
resource.c for reuse by reset restoration. Keep their behavior unchanged
and expose only the cross-object helpers within cxl_core.

I'd very briefly mention that the ordering of patches was chosen for
minimal code churn, but that it necessitates some functions are
use cross module in a fashion that is dropped in later patches.


Signed-off-by: Srirangan Madhavan <smadhavan@xxxxxxxxxx>
Otherwise much more readable! Thanks for splitting it all up
into more bitesized chunks.

Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>

In v14, I refactored the helpers in place and moved them together with the build change in patch 6. That removes the temporary build arrangement you noted.
But I added the review tag.

Thank you.
--
Regards,
Srirangan