[PATCH 3/4] riscv: dts: th1520-lichee-module-4a: Cleanup with dt-check-style

From: Kanak Shilledar

Date: Fri Oct 02 2026 - 09:45:14 EST


Fix warnings thrown by krzk's recent updates to the dt-check-style
tool when run with strict mode. Fix the following warnings:

thead/th1520-lichee-module-4a.dtsi:62: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
thead/th1520-lichee-module-4a.dtsi:66: [required-blank-lines] "status" must be preceded by a blank line
thead/th1520-lichee-module-4a.dtsi:129: [child-name-order] child node 'rx-pins' out of name order

After this patch, there are no more warnings left. Fix these warnings
to make the file more readable and maintainable along with that to
make it more compliant with the devicetree specifications.

Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
---
.../boot/dts/thead/th1520-lichee-module-4a.dtsi | 56 ++++++++++++----------
1 file changed, 30 insertions(+), 26 deletions(-)

diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
index 8e76b63e0100a..e8930e994e91a 100644
--- a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
+++ b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
@@ -47,22 +47,25 @@ &emmc {
non-removable;
no-sdio;
no-sd;
+
status = "okay";
};

&gmac0 {
- pinctrl-names = "default";
pinctrl-0 = <&gmac0_pins>, <&mdio0_pins>;
+ pinctrl-names = "default";
phy-handle = <&phy0>;
phy-mode = "rgmii-id";
+
status = "okay";
};

&gmac1 {
- pinctrl-names = "default";
pinctrl-0 = <&gmac1_pins>;
+ pinctrl-names = "default";
phy-handle = <&phy1>;
phy-mode = "rgmii-id";
+
status = "okay";
};

@@ -111,21 +114,6 @@ phy1: ethernet-phy@2 {

&padctrl0_apsys {
gmac0_pins: gmac0-0 {
- tx-pins {
- pins = "GMAC0_TX_CLK",
- "GMAC0_TXEN",
- "GMAC0_TXD0",
- "GMAC0_TXD1",
- "GMAC0_TXD2",
- "GMAC0_TXD3";
- function = "gmac0";
- bias-disable;
- drive-strength = <25>;
- input-disable;
- input-schmitt-disable;
- slew-rate = <0>;
- };
-
rx-pins {
pins = "GMAC0_RX_CLK",
"GMAC0_RXDV",
@@ -140,24 +128,24 @@ rx-pins {
input-schmitt-disable;
slew-rate = <0>;
};
- };

- gmac1_pins: gmac1-0 {
tx-pins {
- pins = "GPIO2_18", /* GMAC1_TX_CLK */
- "GPIO2_20", /* GMAC1_TXEN */
- "GPIO2_21", /* GMAC1_TXD0 */
- "GPIO2_22", /* GMAC1_TXD1 */
- "GPIO2_23", /* GMAC1_TXD2 */
- "GPIO2_24"; /* GMAC1_TXD3 */
- function = "gmac1";
+ pins = "GMAC0_TX_CLK",
+ "GMAC0_TXEN",
+ "GMAC0_TXD0",
+ "GMAC0_TXD1",
+ "GMAC0_TXD2",
+ "GMAC0_TXD3";
+ function = "gmac0";
bias-disable;
drive-strength = <25>;
input-disable;
input-schmitt-disable;
slew-rate = <0>;
};
+ };

+ gmac1_pins: gmac1-0 {
rx-pins {
pins = "GPIO2_19", /* GMAC1_RX_CLK */
"GPIO2_25", /* GMAC1_RXDV */
@@ -172,6 +160,21 @@ rx-pins {
input-schmitt-disable;
slew-rate = <0>;
};
+
+ tx-pins {
+ pins = "GPIO2_18", /* GMAC1_TX_CLK */
+ "GPIO2_20", /* GMAC1_TXEN */
+ "GPIO2_21", /* GMAC1_TXD0 */
+ "GPIO2_22", /* GMAC1_TXD1 */
+ "GPIO2_23", /* GMAC1_TXD2 */
+ "GPIO2_24"; /* GMAC1_TXD3 */
+ function = "gmac1";
+ bias-disable;
+ drive-strength = <25>;
+ input-disable;
+ input-schmitt-disable;
+ slew-rate = <0>;
+ };
};

mdio0_pins: mdio0-0 {
@@ -200,5 +203,6 @@ mdio-pins {
&sdio0 {
bus-width = <4>;
max-frequency = <198000000>;
+
status = "okay";
};

--
2.43.0