[PATCH 1/4] riscv: dts: thead: beaglev-ahead: Cleanup with dt-check-style
From: Kanak Shilledar
Date: Fri Oct 02 2026 - 09:45:27 EST
A lot of warnings were thrown via krzk's updates to the dt-check-style
tool. These were observed when running the tool in strict mode. Most
of the issues were related to missing blank lines and out of order
properties and nodes such as:
thead/th1520-beaglev-ahead.dts:43: [child-name-order] child node 'leds' out of name order
thead/th1520-beaglev-ahead.dts:46: [property-order] property 'compatible' out of canonical order (should sort before 'pinctrl-0')
thead/th1520-beaglev-ahead.dts:79: [child-name-order] child node 'hdmi-connector' out of name order
thead/th1520-beaglev-ahead.dts:115: [required-blank-lines] "status" must be preceded by a blank line
[...]
Fix these warnings to make the file more readable and maintainable
along with that to make it more compliant with the devicetree
specifications.
Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
---
arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 119 +++++++++++----------
1 file changed, 62 insertions(+), 57 deletions(-)
diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
index e16484a476534..426890f812745 100644
--- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
+++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
@@ -35,15 +35,21 @@ chosen {
stdout-path = "serial0:115200n8";
};
- memory@0 {
- device_type = "memory";
- reg = <0x0 0x00000000 0x1 0x00000000>;
+ hdmi-connector {
+ compatible = "hdmi-connector";
+ type = "d";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
};
leds {
- pinctrl-names = "default";
- pinctrl-0 = <&led_pins>;
compatible = "gpio-leds";
+ pinctrl-0 = <&led_pins>;
+ pinctrl-names = "default";
led-1 {
gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>;
@@ -76,15 +82,9 @@ led-5 {
};
};
- hdmi-connector {
- compatible = "hdmi-connector";
- type = "d";
-
- port {
- hdmi_con_in: endpoint {
- remote-endpoint = <&hdmi_out_con>;
- };
- };
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x00000000 0x1 0x00000000>;
};
wifi_pwrseq: wifi-pwrseq {
@@ -112,14 +112,16 @@ &emmc {
non-removable;
no-sdio;
no-sd;
+
status = "okay";
};
&gmac0 {
- pinctrl-names = "default";
pinctrl-0 = <&gmac0_pins>;
+ pinctrl-names = "default";
phy-handle = <&phy0>;
phy-mode = "rgmii-id";
+
status = "okay";
};
@@ -153,36 +155,6 @@ led-pins {
&padctrl0_apsys {
gmac0_pins: gmac0-0 {
- tx-pins {
- pins = "GMAC0_TX_CLK",
- "GMAC0_TXEN",
- "GMAC0_TXD0",
- "GMAC0_TXD1",
- "GMAC0_TXD2",
- "GMAC0_TXD3";
- function = "gmac0";
- bias-disable;
- drive-strength = <25>;
- input-disable;
- input-schmitt-disable;
- slew-rate = <0>;
- };
-
- rx-pins {
- pins = "GMAC0_RX_CLK",
- "GMAC0_RXDV",
- "GMAC0_RXD0",
- "GMAC0_RXD1",
- "GMAC0_RXD2",
- "GMAC0_RXD3";
- function = "gmac0";
- bias-disable;
- drive-strength = <1>;
- input-enable;
- input-schmitt-disable;
- slew-rate = <0>;
- };
-
mdc-pins {
pins = "GMAC0_MDC";
function = "gmac0";
@@ -203,6 +175,16 @@ mdio-pins {
slew-rate = <0>;
};
+ phy-interrupt-pins {
+ pins = "GMAC0_CRS"; /* GPIO3_22 */
+ function = "gpio";
+ bias-pull-up;
+ drive-strength = <1>;
+ input-enable;
+ input-schmitt-enable;
+ slew-rate = <0>;
+ };
+
phy-reset-pins {
pins = "GMAC0_COL"; /* GPIO3_21 */
bias-disable;
@@ -212,28 +194,38 @@ phy-reset-pins {
slew-rate = <0>;
};
- phy-interrupt-pins {
- pins = "GMAC0_CRS"; /* GPIO3_22 */
- function = "gpio";
- bias-pull-up;
+ rx-pins {
+ pins = "GMAC0_RX_CLK",
+ "GMAC0_RXDV",
+ "GMAC0_RXD0",
+ "GMAC0_RXD1",
+ "GMAC0_RXD2",
+ "GMAC0_RXD3";
+ function = "gmac0";
+ bias-disable;
drive-strength = <1>;
input-enable;
- input-schmitt-enable;
+ input-schmitt-disable;
slew-rate = <0>;
};
- };
- uart0_pins: uart0-0 {
tx-pins {
- pins = "UART0_TXD";
- function = "uart";
+ pins = "GMAC0_TX_CLK",
+ "GMAC0_TXEN",
+ "GMAC0_TXD0",
+ "GMAC0_TXD1",
+ "GMAC0_TXD2",
+ "GMAC0_TXD3";
+ function = "gmac0";
bias-disable;
- drive-strength = <3>;
+ drive-strength = <25>;
input-disable;
input-schmitt-disable;
slew-rate = <0>;
};
+ };
+ uart0_pins: uart0-0 {
rx-pins {
pins = "UART0_RXD";
function = "uart";
@@ -243,6 +235,16 @@ rx-pins {
input-schmitt-enable;
slew-rate = <0>;
};
+
+ tx-pins {
+ pins = "UART0_TXD";
+ function = "uart";
+ bias-disable;
+ drive-strength = <3>;
+ input-disable;
+ input-schmitt-disable;
+ slew-rate = <0>;
+ };
};
wifi_pins: wifi-0 {
@@ -271,19 +273,21 @@ reg-on-pins {
&sdio0 {
bus-width = <4>;
max-frequency = <198000000>;
+
status = "okay";
};
&sdio1 {
bus-width = <4>;
max-frequency = <198000000>;
- pinctrl-names = "default";
pinctrl-0 = <&wifi_pins>;
+ pinctrl-names = "default";
#address-cells = <1>;
#size-cells = <0>;
non-removable;
keep-power-in-suspend;
mmc-pwrseq = <&wifi_pwrseq>;
+
status = "okay";
wifi@1 {
@@ -310,7 +314,8 @@ hdmi_out_con: endpoint {
};
&uart0 {
- pinctrl-names = "default";
pinctrl-0 = <&uart0_pins>;
+ pinctrl-names = "default";
+
status = "okay";
};
--
2.43.0