Re: [PATCH v5 1/8] serial: max310x: don't clobber the TX break bit in set_termios

[Hugo Villeneuve]

On Fri, 2 Oct 2026 10:25:13 +0300
Tapio Reijonen <tapio.reijonen@xxxxxxxxxxx> wrote:

> Hi Hugo,
> 
> On Tue, 29 Sep 2026 09:40:19 -0400, Hugo Villeneuve wrote:
> > > max310x_set_termios() writes the LCR register absolutely, but LCR
> > > also
> >
> > What do you mean by "absolutely"? I think you should rephrase that...
> 
> Agreed, that reads wrong. v6 says "unconditionally"/"unconditional"
> instead, in the commit message and in both code comments (the short
> one added here and the expanded one in the software-RTS patch).

Ok, so if I understand correctly you mean that max310x_set_termios()
overwrites the whole LCR register?



-- 
Hugo Villeneuve