Re: [PATCH v5 1/8] serial: max310x: don't clobber the TX break bit in set_termios

From: Tapio Reijonen

Date: Sun Oct 04 2026 - 06:46:01 EST


Hi Hugo,

On 10/2/26 18:03, Hugo Villeneuve wrote:
> Ok, so if I understand correctly you mean that max310x_set_termios()
> overwrites the whole LCR register?

Yes, exactly: it computes the word length, parity and stop bits from
termios and writes the whole register, so the TX break bit (and the
RTS pin control bit) are zeroed on every termios change. Your phrasing
is clearer than mine - v6 will say "overwrites the whole LCR register".

Tapio