Re: [PATCH v3 2/2] EDAC/amd64: Set zn_regs_v2 for all Family 1Ah models

[Yazen Ghannam]

On Fri, Oct 02, 2026 at 06:22:38PM -0700, Borislav Petkov wrote:
> On Fri, Oct 02, 2026 at 05:02:04PM +0530, Vishal Badole wrote:
> > All Family 1Ah models use the v2 register layout. Today zn_regs_v2 is
> > set in each model case. This works, but a new model could forget to set
> > it and read the UMC registers at the wrong offsets.
> > 
> > Set zn_regs_v2 once at the Family 1Ah level so it applies to all models
> > uniformly, and drop the per-model assignments.
> > 
> > No functional change intended.
> > 
> > Suggested-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> > Signed-off-by: Vishal Badole <Vishal.Badole@xxxxxxx>
> > Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> > ---
> >  drivers/edac/amd64_edac.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> > index 0c0d11c72925..708fc1b4a999 100644
> > --- a/drivers/edac/amd64_edac.c
> > +++ b/drivers/edac/amd64_edac.c
> > @@ -3887,23 +3887,19 @@ static int per_family_init(struct amd64_pvt *pvt)
> >  		break;
> >  
> >  	case 0x1A:
> > +		pvt->flags.zn_regs_v2   = 1;
> > +
> >  		switch (pvt->model) {
> >  		case 0x00 ... 0x1f:
> >  			pvt->max_mcs            = 12;
> > -			pvt->flags.zn_regs_v2   = 1;
> > -			break;
> > -		case 0x40 ... 0x4f:
> 		^^^^^^^^^^^^^^^^^^^
> 
> Why?
> 
> > -			pvt->flags.zn_regs_v2   = 1;
> >  			break;

Because it becomes an empty case once this flag set is moved up.

Thanks,
Yazen