Re: [PATCH] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004

[Tzung-Bi Shih]

On Sat, Oct 03, 2026 at 06:28:53PM -0400, James Fairweather wrote:
> Only read the parent's driver data when the parent's ACPI node is
> GOOG0004, and otherwise continue without an EC pointer. While at it,
> drop the reference taken by fwnode_get_parent().

Because of this, I'll add "Fixes: e4ee0bb077cd ..." as well when applying
the patch.

> Tested on a Google Nami-based Chromebook (BIOS 09/19/2019)
> running a 7.2.5 distro kernel (linux-omarchy 7.2.5-3). The unpatched
> driver oopsed twice in two days, each time on a charger plug/unplug.
> With this patch built as a module against that kernel, the probe logs
> "Couldn't get Chrome EC device pointer." (confirming GOOG0003's parent
> is not GOOG0004 here), and 12 charger unplug/replug cycles produced no
> oops, with charging negotiating 20V/3.5A as before.

Hi James,

Thanks for looking into this.

Sergey Tiraspolsky ran into the same issue on a Pixelbook (Eve) and sent a
patch shortly before yours [1].  However, because your patch also catches
and resolves the preexisting fwnode reference leak, I plan to proceed with
your patch.

When applying, I plan to credit Sergey's earlier report by adding a
"Reported-by" tag.  I've also CC'd Sergey and invited testing on Eve if
feasible.

[1] https://lore.kernel.org/all/20261003204623.18124-1-stiraspo@xxxxxxxxx/