Re: [PATCH] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004
From: Sergey Tiraspolsky
Date: Tue Oct 06 2026 - 03:16:22 EST
On Sat, Oct 03, 2026 at 06:28:53PM -0400, James Fairweather wrote:
> Only read the parent's driver data when the parent's ACPI node is
> GOOG0004, and otherwise continue without an EC pointer. While at it,
> drop the reference taken by fwnode_get_parent().
Tested on a 2017 Google Pixelbook (Eve), where GOOG0003 is also a child
of PNP0C09, on 7.2.5 (linux-omarchy 7.2.5-3), with this patch built as an
out-of-tree module. The probe prints "Couldn't get Chrome EC device
pointer.", a charger unplug/replug while awake and another while
suspended produced 13 USB PD notifications, all taking the "EC device
inaccessible; sending 0 event status" path, the suspend resumed normally,
and there were no oopses. Without a fix the same machine oopsed on
charger events and on resume.
The test was set up and checked with the help of an AI coding assistant;
I ran it on the hardware.
Tested-by: Sergey Tiraspolsky <stiraspo@xxxxxxxxx>