Re: [PATCH v2] platform/x86: toshiba_haps: Remove unnecessary ret in toshiba_haps_resume()
From: Ilpo Järvinen
Date: Mon Oct 05 2026 - 11:41:47 EST
On Sat, 01 Aug 2026 00:00:07 +0900, Sang-Heon Jeon wrote:
> The return value of toshiba_haps_protection_level() is ignored because
> ret is immediately overwritten by the toshiba_haps_reset_protection()
> call.
>
> And ret is only used by the check, which has no effect because both
> branches return the same value. So remove the check and ret, and
> return the value directly.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] platform/x86: toshiba_haps: Remove unnecessary ret in toshiba_haps_resume()
commit: a3d87f9f5408c137895667475ac730bbae829360
--
i.