Re: [PATCH v3] platform/x86: hp-bioscfg: remove dead bounds check in audit_log_entries_show
From: Ilpo Järvinen
Date: Mon Oct 05 2026 - 11:41:59 EST
On Sat, 19 Sep 2026 11:11:08 +0500, Muhammad Bilal wrote:
> audit_log_entries_show() checks "count * LOG_ENTRY_SIZE > PAGE_SIZE"
> prior to entering the loop. Because "count" is already bounded to fit
> within PAGE_SIZE, the inner loop check "(LOG_ENTRY_SIZE * i) > PAGE_SIZE"
> can never be reached and is dead code.
>
> Remove the redundant inner bounds check and eliminate the unnecessary
> "else" block after "break" to clean up the loop control flow.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] platform/x86: hp-bioscfg: remove dead bounds check in audit_log_entries_show
commit: c0c6999b8cff6fbb8b2511b37e74a03a2538e260
--
i.