Re: [PATCH rtw-next v7 4/6] wifi: rtw88: 8723b: add the RTL8723B chip driver

[Bitterblue Smith]

On 06/10/2026 03:39, Ping-Ke Shih wrote:
> Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
>> On Mon Oct 5, 2026 at 8:08 AM CEST, Ping-Ke Shih wrote:
>>> Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
>> [...]
>>>> +/*
>>>> + * Shares the receive PHY status layout, the SDIO aggregation burst fields
>>>> + * and a few baseband registers with the RTL8703B; reuse that header.
>>>> + */
>>>> +#include "rtw8703b.h"
>>>
>>> Which layout you are using?
>>> Should you move the layout to rtw8723x.h ?
>>>
>>
>> The layout I reuse is the RTL8703B receive PHY status structure, struct
>> phy_status_8703b, together with the SDIO aggregation burst fields and four
>> baseband registers. 
> 
> Let's use another patch to move the struct out of rtw8703b.h, and rename
> to phy_status_8723x for example.
> 

The same struct could be used by other chips in the future, like
RTL8192EE/RTL8192EU and RTL8188FU/RTL8189FS.