Re: [PATCH rtw-next v7 4/6] wifi: rtw88: 8723b: add the RTL8723B chip driver

[Luka Gejak]

October 6, 2026 at 13:18, "Bitterblue Smith" <rtl8821cerfe2@xxxxxxxxx mailto:rtl8821cerfe2@xxxxxxxxx?to=%22Bitterblue%20Smith%22%20%3Crtl8821cerfe2%40gmail.com%3E > wrote:


> 
> On 06/10/2026 03:39, Ping-Ke Shih wrote:
> 
> > 
> > Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> > 
> > > 
> > > On Mon Oct 5, 2026 at 8:08 AM CEST, Ping-Ke Shih wrote:
> > > 
> >  Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> > 
> > > 
> > > [...]
> > > 
> >  +/*
> >  + * Shares the receive PHY status layout, the SDIO aggregation burst fields
> >  + * and a few baseband registers with the RTL8703B; reuse that header.
> >  + */
> >  +#include "rtw8703b.h"
> > 
> >  Which layout you are using?
> >  Should you move the layout to rtw8723x.h ?
> > 
> > > 
> > > The layout I reuse is the RTL8703B receive PHY status structure, struct
> > >  phy_status_8703b, together with the SDIO aggregation burst fields and four
> > >  baseband registers.
> > > 
> >  
> >  Let's use another patch to move the struct out of rtw8703b.h, and rename
> >  to phy_status_8723x for example.
> > 
> The same struct could be used by other chips in the future, like
> RTL8192EE/RTL8192EU and RTL8188FU/RTL8189FS.
>

It probably could. The layout is the vendor driver's
phy_status_rpt_8192cd, used across the 8192cd generation of 11n chips.

I kept the 8723x name and rtw8723x.h for now because the only users in
rtw88 today are the RTL8703B and the RTL8723B. When the RTL8192EE/EU
or RTL8188FU/FS drivers are upstreamed they can be pointed at this
struct and it can be renamed and moved then. Same way this patch makes
for rtw8703b.h.

Best regards,
Luka Gejak