Re: [PATCH v2] sched/cache: Honor asym packing over cache aware scheduling on hybrid systems

[Tim Chen]

On Tue, 2026-10-06 at 16:59 +0300, Kayra Cizmeci wrote:
> Hi Tim,
> 
> > +	/*
> > +	 * On asym packing domains, if the destination CPU
> > +	 * has higher priority than all CPUs in the source group,
> > +	 * prioritize asym packing.
> > +	 */
> > +	if ((env->sd->flags & SD_ASYM_PACKING) &&
> > +	    sgs->group_asym_packing)
> > +		return false;
> > +
> 
> I think that check is redundant. group_asym_packing is set by sched_group_asym() and bunch of other stuff,
> but sched_group_asym() calls sched_asym() and sched_asym() calls sched_use_asym_prio() that has SD_ASYM_PACKING check
> inside of it.


Thanks.  Yes, we can remove the SD_ASYM_PACKING check as the check was done when group_asym_packing was set.

Tim

> 
> Ah.. Hope I'm not missing something...
> 
> Reviewed-by: Kayra Cizmeci <kayracizmeci@xxxxxxxxx>
> 
> Now, I'm going to grab a cup of tea. And sleep.
> 
>