Re: [PATCH] ocfs2/dlm: Serialize recovery list teardown with debug reads

From: Cen Zhang

Date: Sun Oct 11 2026 - 12:09:48 EST


Hi Joseph,

Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx> 于2026年10月10日周六 16:48写道:
>
> The race looks real.
>
> But I don't want to involve dlm->spinlock for list dlm->reco.node_data.
> While dlm_reco_state_lock is the designed lock to protect list
> dlm->reco.node_data.
>
> So why not add the dlm_reco_state_lock in debug_state_print()? This
> can keep consitent with all other places that access list
> dlm->reco.node_data.
>
> Also it seems also fixes the potential list_add_tail() race in
> dlm_init_recovery_area().
>
> Thanks,
> Joseph
>

Thanks for your review.

I will revise the patch as you suggest.

Best regards,
Cen Zhang