Re: [PATCH v19 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags

[Ratheesh Kannoth]

On 2026-10-10 at 15:31:08, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 (3) · Medium: 1 (5) · Low: 0 (1)
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] otx2_sync_flags_from_rep() (otx2_common.h:625-634) updates the
>   shared priv->flags word with a plain read-modify-write:…
Pre-exisisting issues.

> - [Medium] The commit message presents this as a cleanup to atomic
>   bitops, but the patch also fixes a user-visible representor bug and…
This is side effect of the fix, not intended one.