RE: [PATCH rtw-next v5 2/3] wifi: rtw88: update the beacon from a wiphy work

[Ping-Ke Shih]

Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
 
> Mehmet Fide <mehmet.fide@xxxxxxxxx> wrote:
> > From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
> >
> > set_tim() queues update_beacon_work to rebuild the reserved page with
> > the new TIM. Make it a wiphy work so that it runs under the wiphy lock
> > like the other beacon downloads and can look at mac80211 state;
> 
> What "mac80211 state" did you mean? Without wiphy_work, it can't state
> it?
> 
> > the
> > next patch needs that to tell whether a channel switch is being
> > announced.
> >
> > rtw_core_stop() runs without the wiphy lock on the IPS path and can no
> > longer cancel the work, so the work checks RTW_FLAG_RUNNING under the
> > driver mutex instead, as the watchdog and the C2H work do.

(forgot to say)

Or you should add wiphy lock on IPS path, and cancel the work.

> 
> rtw88 doesn't use wiphy work/lock yet. and you are the first one to use
> wiphy_work. Mixing to use wiphy work/lock and ieee80211_work with driver
> lock looks not good. Should we just use ieee80211_work to avoid confusing?
> 
> Or we should migrate to wiphy work/lock?
> 
> For me, I prefer you use ieee80211_work with driver lock for now, because
> I guess I don't have time to verify the migration...
> 
> Ping-Ke
>