Re: [PATCH] tpm: clean up error checking in setup_ring()

From: Markus Elfring

Date: Mon Oct 12 2026 - 04:04:13 EST


>>> The bind_evtchn_to_irqhandler() function can never return 0.
…
> I do agree that something in this patch does not appear right, or
> at least not very well explained so it is a good catch anyhow.
>
> My decision on this is that:
>
> 1. I'll drop the current patch as it actually does not make a case
> why zero could not possibly happen. I spent 45 minutes browsing
> because commit message did not have any technical details.…

How does this response fit to your previous tag “Reviewed-by”?

Dan Carpenter provided also some hints.

Regards,
Markus