Re: [PATCH] tpm: clean up error checking in setup_ring()

[Jarkko Sakkinen]

On Mon, Oct 12, 2026 at 10:03:09AM +0200, Markus Elfring wrote:
> >>> The bind_evtchn_to_irqhandler() function can never return 0.
> …
> > I do agree that something in this patch does not appear right, or 
> > at least not very well explained so it is a good catch anyhow.
> > 
> > My decision on this is that:
> > 
> > 1. I'll drop the current patch as it actually does not make a case
> >    why zero could not possibly happen. I spent 45 minutes browsing
> >    because commit message did not have any technical details.…
> 
> How does this response fit to your previous tag “Reviewed-by”?
> 
> Dan Carpenter provided also some hints.

There's no problem with this. I sanity checked the commit because I
did not (and do not) understand what you wrote, and started to
check up on things because of that email.

I came into conclusion that the commit message does not nail down
its claim well enough so I did the only common sense action one
can do in this situation.

> 
> Regards,
> Markus

Br, Jarkko