Re: [PATCH v3 1/7] ASoC: dt-bindings: ti,pcm1681: Document the optional SCK clock
From: Krzysztof Kozlowski
Date: Tue Oct 13 2026 - 03:01:25 EST
On Fri, Oct 09, 2026 at 06:42:47PM +0530, Mohammad Rafi Shaik wrote:
> The PCM1681 can use an external system clock supplied on the SCK input
> pin. Platforms that provide this clock need a way to describe the clock
> connection in Device Tree.
>
> Document the optional 'clocks' and 'clock-names' properties and define
> the clock name as "sck" to represent the external system clock source.
>
> This allows boards using an externally supplied SCK clock to accurately
> describe the hardware configuration.
>
> Reviewed-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/sound/ti,pcm1681.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml
> index 1f0e6787a..1b3803518 100644
> --- a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml
> @@ -21,6 +21,13 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> + description: System clock (SCK)
> +
> + clock-names:
> + const: sck
Drop the names. If they are needed for any reason, then use the same
name other device uses already, so scki.
Best regards,
Krzysztof