Re: [PATCH net-next v23 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Kyle Switch]

On 10/13/26 10:13, Andrew Lunn wrote:
> > +static int yt8824_config_utp_init_paged(struct phy_device *phydev)
> > +{
> > +	/* enable nibble */
> > +	ctrl = FIELD_PREP(YT8824_U0_U1_ENABEL_ODD_PREAMBLE, 3);
> > +	mask = YT8824_U0_U1_ENABEL_ODD_PREAMBLE;
> ENABLE.
>
> > +	/* 2.5G template tone */
> > +	ctrl = FIELD_PREP(YT8824_POWER_SAVIE, 0x83);
> > +	mask = YT8824_POWER_SAVIE;
> Is this meant to be SAVE?

yes. sorry for the spelling mistakes. In the next version, I'll check 
the spelling

of all macros added earlier.

> 	Andrew