Re: [PATCH net] net/mlx5: DPLL, fix fractional frequency offset scaling
From: Daniel Machon
Date: Thu Oct 15 2026 - 06:57:00 EST
> From: Carolina Jubran <cjubran@xxxxxxxxxx>
>
> The frequency_diff is reported by firmware in parts-per-trillion, which
> is exactly what the DPLL core now expects from the ffo_get callback.
>
> Commit bc443c253fcd ("dpll: expose fractional frequency offset in ppt")
> switched the callback contract to ppt but assumed frequency_diff was in
> ppm and scaled it by 1000000 to "convert" it. Since the value was
> already ppt, this makes both exported attributes wrong.
>
> Report frequency_diff as is and let the core divide it down for the
> legacy ppm attribute.
Reviewed-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>