Re: [PATCH v2 4/4] scsi: ufs: core: Remove an always-false WARN_ONCE()

From: Bart Van Assche

Date: Mon Oct 19 2026 - 16:45:45 EST


On 10/17/26 1:44 AM, Stanley Jhu wrote:
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 44e571757535..716dab2352e9 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6059,9 +6059,6 @@ static unsigned long __ufshcd_clear_outstanding_reqs(struct ufs_hba *hba,
unsigned long completed_reqs = mask & hba->outstanding_reqs;
lockdep_assert_held(&hba->outstanding_lock);
- WARN_ONCE(completed_reqs & ~hba->outstanding_reqs,
- "completed: %#lx; outstanding: %#lx\n", completed_reqs,
- hba->outstanding_reqs);
if (from_irq) {
/* Do not complete polled requests from interrupt context. */
ufshcd_clear_polled(hba, &completed_reqs);

This patch should either be the first patch in this series or should be
squashed into patch 1/4 from this series.

Thanks,

Bart.