Re: [PATCH v2 1/3] watchdog: dw_wdt: use devm_reset_control_get_optional_shared_deasserted

[Tzung-Bi Shih]

On Fri, Oct 23, 2026 at 07:51:00PM +0300, Artem Shimko wrote:
> On Fri, Oct 23, 2026 at 6:05 AM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> 
> > The driver has been "quiet" in probe().  After the change, it starts to be
> > less quiet.
> 
> Thank you for your review.
> 
> It was based on other drivers (as example [1][2]) which use
> dev_err_probe() after
> devm_reset_control_get_optional_exclusive_deasserted() / reset_deassert().
> If you think this dev_err_probe() isn't needed, i can replace it with a return.

That would be great.  It seems v3 still preserves it.  I have no strong
opinion but just wanted to be consistent in the driver.

> 
> [1] drivers/i2c/busses/i2c-designware-platdrv.c:163
> [2] drivers/tty/serial/8250/8250_dw.c:731

---
Please reply-all next time so that the discussion remains visible to folks
on the mailing lists.