Re: [PATCH] staging: fbtft: Remove unused macro

From: Andy Shevchenko

Date: Mon Oct 26 2026 - 05:23:26 EST


On Mon, Oct 26, 2026 at 01:48:32PM +0530, himanshu bakshi wrote:
> From: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
>
> fbtft_init_dbg is not used in drivers/staging/fbtft directory and

We refer to the functions and semantically similar macros as
func() or macro() in the text and comments.

> since dev_dbg messages are good enough, fbtft_init_dbg should be

Ditto for both dev_dbg() and fbtft_init_dbg().

> removed. After compiling the driver, there are no undefined macro
> issues.

> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
> ---

It doesn't say how you tested this, though.

...

Code wise LGTM.

--
With Best Regards,
Andy Shevchenko